junrushao1994 commented on a change in pull request #8817:
URL: https://github.com/apache/tvm/pull/8817#discussion_r694378080



##########
File path: src/support/array.h
##########
@@ -67,6 +68,73 @@ inline bool ArrayWithSameContent(const std::vector<T*>& a, 
const std::vector<T*>
   return true;
 }
 
+/*!
+ * \brief Convert a tvm::runtime::Array to std::vector
+ * \tparam TSrc The type of elements in the source Array
+ * \tparam TDst The type of elements in the result vector
+ * \return The result vector
+ */
+template <class TSrc, class TDst>
+std::vector<TDst> AsVector(const Array<TSrc>& vec);
+/**************** AsVector<TSrc, TDst> ****************/

Review comment:
       add a line before the comments, also say it is implementation details
   
   ```C++
   /**************** Details: AsVector<TSrc, TDst> ****************/
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to