guberti commented on a change in pull request #8748:
URL: https://github.com/apache/tvm/pull/8748#discussion_r695257314
##########
File path: apps/microtvm/reference-vm/base-box-tool.py
##########
@@ -439,26 +473,27 @@ def parse_args():
"--provider",
choices=ALL_PROVIDERS,
action="append",
- help="Name of the provider or providers to act on; if not specified,
act on all.",
+ required=True,
+ help="Name of the provider or providers to act on",
)
- parser.add_argument(
- "platform",
- help="Name of the platform VM to act on. Must be a sub-directory of
this directory.",
- )
+ # "test" has special options for different platforms, and "build",
"release" might
+ # in the future, so we'll add the platform argument to each one
individually.
+ platform_help_str = "Electronics platform to use (e.g. Arduino, Zephyr)"
Review comment:
I don't think "RTOS platforms to use..." is appropriate, because Arduino
is not an RTOS (nor are other potential platforms like CircuitPython). Arduino
calls itself a "electronic prototyping platform", but that doesn't describe
Zephyr well.
I also don't like "platform to use", since "platform" could be confused with
the other "microtvm-platform" parameter. Thoughts on other phrasings we could
use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
