Mousius commented on a change in pull request #10:
URL: https://github.com/apache/tvm-rfcs/pull/10#discussion_r693990810
##########
File path: rfcs/0010-additional-target-hooks.md
##########
@@ -0,0 +1,155 @@
+Feature Name: additional-target-hooks
+Start Date: 2021-07-14
+RFC PR: apache/tvm-rfcs#10
+GitHub Issue: apache/tvm#8589
+
+# Summary
+[summary]: #summary
+
+In order to enable flexibility in how individual targets are lowered and built
within TVM, this RFC proposes supporting additional hooks on the `Target` and
that the target becomes the central place for such hooks, for example:
Review comment:
I don't see the need to specify "externally-codegen'd" here as if
they're lowered only via `relay_to_tir`, the actual code generation can fall
back to host.
##########
File path: rfcs/0010-additional-target-hooks.md
##########
@@ -0,0 +1,155 @@
+Feature Name: additional-target-hooks
+Start Date: 2021-07-14
+RFC PR: apache/tvm-rfcs#10
+GitHub Issue: apache/tvm#8589
+
+# Summary
+[summary]: #summary
+
+In order to enable flexibility in how individual targets are lowered and built
within TVM, this RFC proposes supporting additional hooks on the `Target` and
that the target becomes the central place for such hooks, for example:
Review comment:
I'd suggest the `Target` provides the best place to add per-`Target`
customisation to the flow in a centralised place which is easy to reason about.
As such, I believe your understanding of what I'm getting at here is correct.
Given that, I believe we can just make this a `Pass` for the `relay_to_tir`
hook, as that aligns neatly with where everyone wants to get to?
One core distinction here is that the `tir_to_runtime` hook isn't a pass,
it's an override of code generation.
##########
File path: rfcs/0010-additional-target-hooks.md
##########
@@ -0,0 +1,155 @@
+Feature Name: additional-target-hooks
Review comment:
I'm not in favour of using `BYOC` here as we're not actually genning
code in all cases, if the host code gen can handle the TIR then it can just
generate itself. The other thing is this RFC introduces the registration of the
hooks on the Target registry. Maybe `Target` compiler flow customisation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
