vinx13 commented on a change in pull request #8851:
URL: https://github.com/apache/tvm/pull/8851#discussion_r697066431



##########
File path: python/tvm/autotvm/measure/measure_methods.py
##########
@@ -114,7 +114,7 @@ def build(self, measure_inputs):
                 futures.append(ret)
 
             for future in futures:
-                res = future.get()
+                res = future.result()

Review comment:
       If the function submitted raise an exception, or timeout occurs, the 
exception will be raised again here. The exception handling here will be 
different from the original way

##########
File path: python/tvm/autotvm/measure/executor.py
##########
@@ -87,6 +87,25 @@ def get(self, timeout=None):
         raise NotImplementedError()
 
 
+class LocalFutureNoFork(Future):

Review comment:
       is it still being used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to