Lunderberg opened a new pull request #8871: URL: https://github.com/apache/tvm/pull/8871
After implementing this, I'm somewhat mixed, and would like to hear what others think. This PR allows a new entry to be added to the `tvm.support.libinfo()` dictionary with a single-line change in `LibInfo.cmake`. However, it does so by generating the C++ source code on the fly, and I'm unsure if that's a good idea or not. Pros: * Previously, exposing a cmake build variable to the compiled program required adding a new `-D` define macro in `LibInfo.cmake`, conditionally setting the `#define` in `libinfo.cc`, then adding it into the list returned by `GetLibInfo`. With this commit, additional cmake build variables can be exposed by adding to the list passed when generating `libinfo.cc`. * Simplifies the CMakeLists.txt, because libinfo no longer needs to be in a separate target to prevent unnecessary recompiling. Downsides: * Introduces a python script to generate `libinfo.cc`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
