guberti commented on pull request #8869: URL: https://github.com/apache/tvm/pull/8869#issuecomment-908607065
> @guberti thanks for this--a couple questions about your test fixtures The more I think about it, the more the `save_generated_project_state` fixture seems like a gross hack. It can create really weird bugs where `microtvm_api_server.py` is still running, but its source file has been repeatedly deleted and restored. Even more so, the idea of having these saved project tests doesn't really fit with the test's "goal" - of simulating a user workflow of building and deploying a model on device. IMO, the cleanest solution is to build a whole new test, `test_arduino_error_detection`, and move them there. I've done that with 3a8ea4c - take a look and LMK if you agree @areusch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
