AndrewZhaoLuo commented on a change in pull request #8626:
URL: https://github.com/apache/tvm/pull/8626#discussion_r698778660
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -3477,6 +3493,8 @@ def _get_convert_map(opset):
"Exp": Renamer("exp"),
"Greater": Greater.get_converter(opset),
"Less": Less.get_converter(opset),
+ "LessOrEqual": LessOrEqual.get_converter(opset),
Review comment:
Can you just use `Renamer`, you are just forwarding the inputs in the
converter?
##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -1927,8 +1927,12 @@ def verify_binary_ops(op, x, y, out_type="float32"):
verify_binary_ops("Sum", x, z)
verify_binary_ops("Greater", x, y, "bool")
verify_binary_ops("Greater", x, z, "bool")
+ verify_binary_ops("GreaterOrEqual", x, y, "bool")
Review comment:
Can you uncomment the appropriate tests in `unsupported_onnx_tests` in
this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
