Mousius commented on a change in pull request #8869: URL: https://github.com/apache/tvm/pull/8869#discussion_r701119135
########## File path: tests/micro/arduino/test_arduino_rpc_server.py ########## @@ -37,8 +37,7 @@ import conftest -# We'll make a new workspace for each test [email protected](scope="function") +# # A new project and workspace dir is created for EVERY test Review comment: Sorry for the confusion, this should just be: ```suggestion @pytest.fixture ``` ########## File path: tests/micro/arduino/test_arduino_error_detection.py ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import pathlib +import re +import sys + +import pytest + +import conftest +from tvm.micro.project_api.server import ServerError + + +# A new project and workspace dir is created for EVERY test +def workspace_dir(request, platform): + return conftest.make_workspace_dir("arduino_error_detection", platform) + + [email protected](scope="function") Review comment: We can remove the `scope` parameter here as well. ########## File path: tests/micro/arduino/test_arduino_error_detection.py ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import pathlib +import re +import sys + +import pytest + +import conftest +from tvm.micro.project_api.server import ServerError + + +# A new project and workspace dir is created for EVERY test Review comment: Sorry for the confusion, this should just be: ```suggestion @pytest.fixture ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
