electriclilies commented on a change in pull request #8886:
URL: https://github.com/apache/tvm/pull/8886#discussion_r701320375
##########
File path: src/relay/backend/graph_executor_codegen.cc
##########
@@ -270,8 +274,13 @@ class GraphExecutorCodegen : public
backend::MemoizedExprTranslator<std::vector<
std::make_pair(static_cast<int>(param_storage_ids_[param.first]),
param.second)));
}
ret.function_metadata = std::move(function_metadata_);
- ret.lowered_funcs = lowered_module.per_target_module;
- ret.external_mods = lowered_module.external_mods;
+
+ Optional<Array<tvm::runtime::Module>> external_modules =
+ lowered_mod->GetAttr<Array<tvm::runtime::Module>>("external_mods");
+ // This is the point where we separate the functions in the module by
target
Review comment:
You're right, I'll add it in here too. Since I'm going to be changing
this part of the code a bunch I am going to leave the checks in for my own
sanity :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
