tqchen commented on a change in pull request #8920:
URL: https://github.com/apache/tvm/pull/8920#discussion_r701873764
##########
File path: include/tvm/node/reflection.h
##########
@@ -386,11 +386,13 @@ inline ReflectionVTable::Registry
ReflectionVTable::Register() {
inline void ReflectionVTable::VisitAttrs(Object* self, AttrVisitor* visitor)
const {
uint32_t tindex = self->type_index();
- if (tindex >= fvisit_attrs_.size() || fvisit_attrs_[tindex] == nullptr) {
+ if (tindex >= fvisit_attrs_.size()) {
Review comment:
This might cause some of the unintended behavior(since for certain
object we might want VisitAttrs to exist and would like to detecting problem by
seeing the error). Would be great if we can directly overload the getattr and
dir on the python container object instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
