AndrewZhaoLuo edited a comment on pull request #8924: URL: https://github.com/apache/tvm/pull/8924#issuecomment-912743241
TVM is a large project with many different contributors and we want to make things like reading the git log simple. Externally we want to encourage people to have good PR hygiene. Now for an internal repo that a select few people are working on it's probably fine to do whatever internally they agree upon. As for TVM CI duration, I understand you want to get these changes in as fast as possible, but unless this is actively unblocking someone or CI I do not see this change as important enough to warrant a rushed job. Anyways, we want discussion on the typing changes and ideally we want those threads to be separate from the hardmax changes. Here is what I suggest. Rewind this PR back to 6a0041d and submit the branch in it's current state as a separate PR. Require merging this PR first before the other. You will have to rebase if new ONNX changes come in, but this provides you an opportunity to add type annotations you would need to add anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
