anwang2009 commented on a change in pull request #8907:
URL: https://github.com/apache/tvm/pull/8907#discussion_r702152497



##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -195,6 +195,17 @@ def _dim_check(attrs):
     return _dim_check, "Only 1d, 2d and 3d kernel supported."
 
 
+def get_scalar(x, params, dtype="float32"):
+    """Helper to get a scalar value for Quantized operators."""
+    if isinstance(x, _expr.Var) and x.name_hint in params:

Review comment:
       QLinearConv depends on falling back to `op.cast` in the case that 
x.name_hint is not in params, not throwing error.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to