junrushao1994 commented on a change in pull request #8943:
URL: https://github.com/apache/tvm/pull/8943#discussion_r704136902



##########
File path: include/tvm/tir/schedule/schedule.h
##########
@@ -305,6 +305,38 @@ class ScheduleNode : public runtime::Object {
   virtual BlockRV CacheWrite(const BlockRV& block_rv, int write_buffer_index,
                              const String& storage_scope) = 0;
   /******** Schedule: Compute location ********/
+  /*!
+   * \brief Move a producer block under the specific loop, and regenerate the 
loops induced by the
+   * block so that the buffer region generated by the producer block could 
cover those regions read
+   * by the consumers. It requires:
+   * 1) The scope block has stage-pipeline property
+   * 2) The given block's subtree of the scope block satisfies compact 
dataflow condition.
+   * i.e. all the blocks in the scope's subtree must be either complete block 
or reduction block
+   * 3) `block` and `loop` are under the same scope, `loop` is not the 
ancestor of `block`
+   * 4) The block is not an output block,
+   * i.e. the buffer regions written by the block are allocated under the 
current scope
+   * 5) All the consumers of the block are under the given loop
+   * \param block_rv The block to be moved
+   * \param loop_rv The loop where the block to be moved under
+   * \param preserve_unit_loops Whether to keep the trivial loops whose 
extents are 1
+   */
+  virtual void ComputeAt(const BlockRV& block_rv, const LoopRV& loop_rv,
+                         bool preserve_unit_loops) = 0;
+  /*!
+   * \brief Move a consumer block under the specific loop, and regenerate the 
loops induced by the
+   * block so that the buffer region generated by the consumer block could 
cover those regions read
+   * by the consumers. It requires:

Review comment:
       I thought I addressed the comment? Would you like to double check?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to