gromero commented on a change in pull request #8950:
URL: https://github.com/apache/tvm/pull/8950#discussion_r704419437
##########
File path: python/tvm/micro/project.py
##########
@@ -92,17 +92,16 @@ class TemplateProject:
"""Defines a glue interface to interact with a template project through
the API Server."""
@classmethod
- def from_directory(cls, template_project_dir, options):
- return cls(client.instantiate_from_dir(template_project_dir), options)
+ def from_directory(cls, template_project_dir):
+ return cls(client.instantiate_from_dir(template_project_dir))
- def __init__(self, api_client, options):
+ def __init__(self, api_client):
self._api_client = api_client
- self._options = options
self._info = self._api_client.server_info_query(__version__)
if not self._info["is_template"]:
raise NotATemplateProjectError()
- def generate_project(self, graph_executor_factory, project_dir):
+ def generate_project(self, graph_executor_factory, project_dir, options):
Review comment:
I see your point and that was exactly what I thought when I was going
for that change. Thanks your comment, it really helps me to understand the
design better and increases my confidence that I'm following the motivations
behind it correctly :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
