ganler edited a comment on pull request #8988: URL: https://github.com/apache/tvm/pull/8988#issuecomment-917354030
@junrushao1994 Thanks for the comments. Yes, they are just some tricky edge cases that users would not intentionally meet in most cases (though it is possible by API misuse). I think they are only useful in some extreme and rare security cases, e.g., some hostile server attack to model servers using tvm. As you said, a more fundamental and elegant workaround would be applying `Optional`, though I found it needs to change countless legacy codebase (e.g., changing many APIs into `Optional<T>` and convert them into `.value()` style). This PR is like a quick fix avoiding most crash issues by such tricky inputs (since the root cause of most issues is that applying data access (`->`) through nullptr). And it only considers avoiding bad inputs from Python API. Since the conclusion seems to be clear (I know you guys are busy and such issues are minor and should not be prioritized), I think we can close this PR and simply record this proposal on the channel. Always tyty for the instant reply and patience ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
