mbs-octoml edited a comment on pull request #8974: URL: https://github.com/apache/tvm/pull/8974#issuecomment-919338851
@Mousius > but the PR touches a lot of unrelated files I'll confess I've been doing the same in my PRs and tend to clean up spelling mistakes and minor style glitches as I encounter them without factoring them out. Absolutely agree ideally they'd go in as 'no semantic change' PRs, but the CI delay and review overhead makes me much more forgiving. That said I left two suggestions to lower the diff. I've also been using "./foo.h" instead of "foo.h" to remind me of the abs imports, but maybe that's just my OCD. Note that the LowerTEPass call was resolving to tec::LowerTEPass only because the first argument is also in tec::, a fairly obscure C++ namespace trick, so I'd agree spelling those out is a Good Thing. @mikepapadim, can you prefix the title with [Relay] to follow convention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
