manupa-arm commented on a change in pull request #8849:
URL: https://github.com/apache/tvm/pull/8849#discussion_r709445247
##########
File path: src/tir/transforms/lower_tvm_builtin.cc
##########
@@ -113,16 +113,6 @@ class BuiltinLower : public StmtExprMutator {
op = stmt.as<AllocateNode>();
// Get constant allocation bound.
int64_t nbytes = GetVectorBytes(op->dtype);
- if (device_type_.defined()) {
Review comment:
Yes, if we want the allocates to be placed on stack in CPU PrimFuncs,
maybe we should gate them to have storage_scope = 'local' and we should
generate TVMBAWs for 'global' allocates -- that could make to work for both
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
