mbs-octoml commented on a change in pull request #9012:
URL: https://github.com/apache/tvm/pull/9012#discussion_r709543170
##########
File path: include/tvm/runtime/logging.h
##########
@@ -395,10 +399,13 @@ class LogMessageVoidify {
inline bool DebugLoggingEnabled() {
static int state = 0;
if (state == 0) {
- if (auto var = std::getenv("TVM_LOG_DEBUG")) {
- if (std::string(var) == "1") {
+ if (const char* var = std::getenv("TVM_LOG_DEBUG")) {
Review comment:
We don't have a consistent style on auto, but generally I spell out the
types except for auto x = make_object<X>(...), auto f = [...](...) {...}, and
iterators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
