Mousius commented on issue #8717:
URL: https://github.com/apache/tvm/issues/8717#issuecomment-920936729


   This looks great @Alex-grovety, a huge improvement! 
   
   As far as next steps, ideally from here: 
https://github.com/apache/tvm/blob/02fbaf0ed9120a8f95155e63de42459f230584aa/python/tvm/relay/qnn/op/legalizations.py#L384-L388
   
   We should default to this schedule if the architecture is not 
`is_aarch64_arm()` and not `"+neon" in target.mattr`, something like:
   ```python
   @qnn_dense_legalize.register("arm_cpu")
   def _qnn_dense_legalize_arm_cpu(attrs, inputs, types):
       # Advanced SIMD present and no dot product extension
       if (is_aarch64_arm() or "+neon" in target.mattr) and not 
is_fast_int8_on_arm():
           return helper_no_fast_int8_hw_legalization(attrs, inputs, types, 
relay.nn.dense)
       return helper_change_dtypes_to_be_same(attrs, inputs, types, 
relay.qnn.op.dense)
   ```
   
   Which would be the schedule you've suggested, as the default schedule for 
the Arm architecture.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to