mbrookhart commented on a change in pull request #9028:
URL: https://github.com/apache/tvm/pull/9028#discussion_r710293142
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -3176,7 +3176,7 @@ def _impl_v10(cls, inputs, attr, params):
@classmethod
def _impl_v13(cls, inputs, attr, params):
data, scale, zp = inputs
- axis = attr.get("axis", 1)
+ axis = attr.get("axis", 0)
Review comment:
I don't think this is correct. The default in the ONNX spec is 1. I
think we should leave it as 1, I think there will be cases that fail with this
change, but have code to check for data with 0D or 1D shapes and set it to 0 in
that case?
https://github.com/onnx/onnx/blob/master/docs/Changelog.md#DequantizeLinear-13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
