mbs-octoml commented on a change in pull request #9012:
URL: https://github.com/apache/tvm/pull/9012#discussion_r710501694
##########
File path: src/runtime/logging.cc
##########
@@ -166,10 +167,127 @@ namespace tvm {
namespace runtime {
namespace detail {
+std::unordered_map<std::string, int> ParseTvmLogDebugSpec(const char*
opt_spec) {
+ // Cache the verbosity level map.
+ std::unordered_map<std::string, int> map;
+ LOG(INFO) << "initializing VLOG map";
+ if (opt_spec == nullptr) {
+ LOG(INFO) << "VLOG disabled, no TVM_LOG_DEBUG environment variable";
+ return map;
+ }
+ std::string spec(opt_spec);
+ // Check we are enabled overall with at least one VLOG option.
+ if (spec.rfind("1;", 0) != 0) {
Review comment:
That's the idiom for checking a string begins with a prefix. It won't
waste time looking though the whole string, just check the first 3 chars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
