mbs-octoml commented on pull request #9038:
URL: https://github.com/apache/tvm/pull/9038#issuecomment-922071624
@electriclilies @mikepapadim @jroesch Here's part 1. Things to watch out for:
- How to I may device_copy.cc branch from context_analysis.cc?
- Did I go too far with device defaulting?
- All the visitor helpers are needed in follow up but not used here, so
sorry it's not obvious why I set things up like that. But suggestion for
reducing code dup would be welcome.
- I tried to make the intro comment comprehensive, let me know what needs
more detail.
- Anything non-obvious.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
