comaniac commented on pull request #9043: URL: https://github.com/apache/tvm/pull/9043#issuecomment-922422357
> > Thanks for the fix. Could you please finish the PR description and add a test case? > > @comaniac thanks for your reply. is there any guideline for `adding a test case`? should I just add some more tests in `test/python/relay/test_json_runtime.py`? Yes. Basically you just need to add a new test or improve an existing test that will fail without this PR, so that we could make sure the fix covered by this PR won't be broken in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
