Mousius commented on pull request #9040: URL: https://github.com/apache/tvm/pull/9040#issuecomment-923791118
Hi @mbrookhart / @Raghav-Chakravarthy, I actually made this mistake in another PR (https://github.com/apache/tvm/pull/8951#discussion_r703703990), the actual rule is that all data members of a class should have the trailing `_` (https://google.github.io/styleguide/cppguide.html#Variable_Names) and should actually all be private with accessor functions if necessary (https://google.github.io/styleguide/cppguide.html#Access_Control). @Raghav-Chakravarthy would it be possible for you to update this PR accordingly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
