AndrewZhaoLuo commented on pull request #9023: URL: https://github.com/apache/tvm/pull/9023#issuecomment-925189236
> It looks good to me given we want to fully support numpy-style negative indexing. On the API side, although I still think we can put this as a helper function in topi instead of a member function of `te::Tensor`, the difference is minimal because we are not making architectural change here. So nice work! > > BTW, shall we add a unittest for this? I'll look into the changes you suggest and add a unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
