junrushao1994 commented on pull request #9061:
URL: https://github.com/apache/tvm/pull/9061#issuecomment-926952259
BTW, here is the convention we are using in TensorIR and meta schedule
project:
- An abstract base class that describe how the interface looks like, e.g.
`Schedule`, `Database`, `Builder`, `Runner`
- Concrete implementation as subclasses are hidden in `src/` folder, and
mostly hidden in cc files, which are not directly visible to developers. For
example, `PyDatabase`, `ConcreteSchedule`
- The abstract class provides factory methods to create these concrete
implementations, whose name is consistent with the names of the subclasses. For
example:
```C++
class Database : ... {
public:
static Database JSONFile(...); // TBD: Rename
static Database SQLiteDB(...);
};
```
And then another problem here is what name should we change `JSONFile` for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
