masahi commented on a change in pull request #9113:
URL: https://github.com/apache/tvm/pull/9113#discussion_r716644828



##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -1279,6 +1293,16 @@ def _impl_v1(cls, inputs, attr, params):
         return inputs[len(inputs) - 1]
 
 
+class SequenceConstruct(OnnxOpConverter):
+    """Operator converter for SequenceConstruct"""
+
+    @classmethod
+    def _impl_v11(cls, inputs, attr, params):
+        if len(inputs) == 1:
+            raise ValueError("Expect 2 or more inputs")
+        return _op.Tuple(inputs)

Review comment:
       Can an ONNX Sequence have dynamic number of elements? I thought that's 
the point. 
   
   In that case, we cannot use Tuple. Tensor array is the right way. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to