manupa-arm edited a comment on pull request #9:
URL: https://github.com/apache/tvm-rfcs/pull/9#issuecomment-928055559
Hi @areusch ,
I have addressed candidate_memory_pool query now.
For your question around fallback :
> where are the "fallback" candidate_memory_pools passed in to the runtime?
The fallback only happens the in the compilation time as per this RFC.
Therefore, by the time USMP is done, one pool will be assigned/decided to the
tir.allocate.
> how should the compiler know which candidate_memory_pools can be fallbacks
for a given buffer (given that it does know a particular buffer needs to be
accessible per-device)
I have added a sentence to explain this. The core compiler should assign the
tir.allocate in each PrimFunc with pool it can access because each PrimFunc
know which target it gets compiled to and each pools know which target could
access them. Initially it will take the priority order the user provides to the
TVMC interface.
> do we need to add an additional field to PoolInfo to identify which
devices can use it? it's fine if this is to be decided in a follow-up RFC, but
can you indicate which one (if you have one in mind) or that one hasn't been
chosen (if not)?
Im pretty sure it is listed as Map<Target,String> target_access; // 'rw' or
'ro' in the PoolInfo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
