mbrookhart commented on a change in pull request #9092:
URL: https://github.com/apache/tvm/pull/9092#discussion_r716960304



##########
File path: python/tvm/topi/x86/depthwise_conv2d.py
##########
@@ -305,6 +305,36 @@ def _schedule_depthwise_conv2d_NCHWc_impl(s, cfg, 
data_vec, kernel_vec, conv_out
     return s
 
 
+def schedule_depthwise_conv2d_nhwc(outs):

Review comment:
       It looks like x86 always packs depthwise conv to NCHWc, so this will 
never get hit on an x86 machine. That makes it feel a little misplaced. Any 
reason not to put it here? 
https://github.com/apache/tvm/blob/main/python/tvm/topi/generic/conv2d.py
   I think that's where a lot of the multi-CPU specialization ends up, i.e, all 
of the int8 kernels for ARM and X86 go through there.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to