mbs-octoml commented on a change in pull request #9130:
URL: https://github.com/apache/tvm/pull/9130#discussion_r717007789
##########
File path: src/parser/parser.cc
##########
@@ -1886,43 +1890,58 @@ Parser InitParser(const std::string& file_name, const
std::string& file_content,
auto tokens_and_table = Tokenize(diag_ctx, source);
auto tokens = tokens_and_table.first;
- auto meta_data_table = tokens_and_table.second;
+ MetaTable meta_data_table = tokens_and_table.second.ToMetadata();
+
+ // Merge any entries in init_meta_table into anything captured in the
#[metadata] section
+ // of the file_content. Metadata references within file_content must use
indexes which account
+ // for this ordering.
+ for (const auto& pair : init_meta_table) {
+ Array<ObjectRef> items;
+ if (meta_data_table.count(pair.first)) {
+ items = meta_data_table[pair.first];
+ }
+ for (const auto& obj : pair.second) {
+ items.push_back(obj);
+ }
+ meta_data_table.Set(pair.first, items);
+ }
Review comment:
Good call - done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
