junrushao1994 commented on a change in pull request #9145:
URL: https://github.com/apache/tvm/pull/9145#discussion_r718167878
##########
File path: src/tir/transforms/lower_match_buffer.cc
##########
@@ -188,25 +188,25 @@ class MatchBufferLower : public StmtExprMutator {
Load load = Downcast<Load>(source_buffer.vload(indices,
source_buffer->dtype));
Bind(buffer->elem_offset, load->index, buffer->name + ".elem_offset");
CHECK(analyzer_.CanProve(truncmod(buffer->elem_offset,
buffer->offset_factor) == 0))
- << "The source elem_offset " << buffer->elem_offset
- << " does not satisfy the offset_factor " << buffer->offset_factor
<< ".";
+ << "The source elem_offset " << load->index << " does not satisfy
the offset_factor "
+ << buffer->offset_factor << ".";
}
// Step 2.3. Check and update strides
// Check if target buffer strides are defined
+ ICHECK(source->region.size() >= buffer->shape.size());
+ size_t offset = source->region.size() - buffer->shape.size();
Review comment:
nit: Let’s avoid size_t here as a general principle (although it’s safe
here being guard by a CHECK)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
