masahi commented on a change in pull request #9146:
URL: https://github.com/apache/tvm/pull/9146#discussion_r718055932
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -1468,18 +1468,26 @@ class Unsqueeze(OnnxOpConverter):
"""Operator converter for Unsqueeze."""
@classmethod
- def _impl_v1(cls, inputs, attr, params):
- axes = sorted(attr["axes"])
+ def run_calculation(cls, tensor, axes):
+ axes = sorted(axes)
for axis in axes:
- inputs[0] = _op.expand_dims(inputs[0], axis=axis, num_newaxis=1)
- return inputs[0]
+ tensor = _op.expand_dims(tensor, axis=axis, num_newaxis=1)
+ return tensor
@classmethod
- def _impl_v12(cls, inputs, attr, params):
+ def _impl_v1(cls, inputs, attr, params):
+ return cls.run_calculation(inputs[0], attr["axes"])
+
+ @classmethod
+ def _impl_v13(cls, inputs, attr, params):
+ if isinstance(inputs[1], _expr.Constant):
Review comment:
I thought axes could also be an Expr involving only constants, but I
hope such weird usage wouldn't happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
