Mousius commented on a change in pull request #9168:
URL: https://github.com/apache/tvm/pull/9168#discussion_r719694491
##########
File path: python/tvm/tir/stmt.py
##########
@@ -318,13 +318,23 @@ class Allocate(Stmt):
body : Stmt
The body statement.
+ annotations: Optional[Mapping[str, Object]]
+ Additional annotation hints
+
span : Optional[Span]
The location of this itervar in the source code.
"""
- def __init__(self, buffer_var, dtype, extents, condition, body, span=None):
+ def __init__(self, buffer_var, dtype, extents, condition, body,
annotations=None, span=None):
self.__init_handle_by_constructor__(
- _ffi_api.Allocate, buffer_var, dtype, extents, condition, body,
span # type: ignore
+ _ffi_api.Allocate,
+ buffer_var,
+ dtype,
+ extents,
+ condition,
+ body,
+ annotations,
+ span, # type: ignore
Review comment:
I think this `# type: ignore` belongs with `_ffi_api.Allocate` as it's
unreachable by `mypy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
