manupa-arm commented on pull request #8892: URL: https://github.com/apache/tvm/pull/8892#issuecomment-932020564
Hi @jroesch , I finally manage to get some time to read this :). I think code looks generally good modulo the comments. I have a broad design question. At which phase, would we be doing the partitioning of devices for same kind ? Confusingly, at the minute we have two annotation (one in the BYOC pipeline) and one internally in the relay lowering pipeline. [Related PRs and discussion : https://github.com/apache/tvm/pull/7428 and https://discuss.tvm.apache.org/t/rfc-composite-target/7744/10? -- cc: @mbs-octoml ] The strategy we are using in the annotation target pass (of the BYOC pipeline -- it does not really need to be just a BYOC thing), is we greedily partition the Relay OPs given the knowledge that some target kinds are better in processing them. Therefore, this is a step beyond that where we have to deal with multiple devices of same kind and brings algorithmic problem of load balancing between devices. I appreciate that it can be a complex problem; however, my immediate question is what is the initial strategy that is being planned to use this from an annotation point of view ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
