spectrometerHBH commented on a change in pull request #9041:
URL: https://github.com/apache/tvm/pull/9041#discussion_r720393958
##########
File path: src/tir/schedule/state.cc
##########
@@ -206,25 +188,11 @@ class StateCreator : private StmtVisitor {
* \param stmt A for-loop statement or a block statement
* \return A sref to the stmt
*/
- StmtSRef PushSRef(const StmtNode* stmt) {
- if (srefs_.empty()) {
- srefs_.push_back(
- StmtSRef(stmt,
- /*parent=*/nullptr,
- /*seq_index=*/-1)); // `seq_index` will be set properly in
SetSeqIndex
- } else {
- StmtSRefNode* parent = srefs_.back().get();
- srefs_.push_back(
- StmtSRef(stmt, parent,
- /*seq_index=*/-1)); // `seq_index` will be set properly in
SetSeqIndex
- }
- return srefs_.back();
- }
+ void PushSRef(const StmtNode* stmt) {
srefs_.push_back(self_->stmt2ref.at(stmt)); }
- /*! \brief Pop the top of the scope and record it in stmt2ref map */
- StmtSRef PopAndRecordSRef() {
- StmtSRef sref = std::move(srefs_.back());
- self_->stmt2ref[sref->stmt] = sref;
+ /*! \brief Pop the top of the scope */
Review comment:
consider `ScheduleStateNode::UpdateSubtreeblockInfo(stmt)`
If stmt is a Block, which means the outer loops of Block are not passed into
the function, then we should expect the Block to be root(i.e. it doesn't have
outer loops).
If stmt is a Loop, the the blocks under the loop can not be judged as root
block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
