mbs-octoml commented on a change in pull request #8788:
URL: https://github.com/apache/tvm/pull/8788#discussion_r721519178
##########
File path: include/tvm/relay/transform.h
##########
@@ -165,11 +165,12 @@ TVM_DLL Pass ToANormalForm();
/*!
* \brief ToANormalForm but on incomplete graph.
*
+ * \param maybe_mod optional module holding definitions for global vars in \p
expr
* \param expr the graph.
*
* \return The transformed program.
*/
-TVM_DLL Expr ToANormalForm(const Expr& expr);
+TVM_DLL Expr ToANormalForm(const Optional<IRModule>& maybe_mod, const Expr&
expr);
Review comment:
Now that I think about it again I don't need this argument -- if during
conversion to ANF the pass asks for the device for a global var then it is only
for the purposes of maybe wrapping the same global var with an "on_device"
annotation, but that is always a no-op. I''ll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
