huajsj commented on a change in pull request #9108: URL: https://github.com/apache/tvm/pull/9108#discussion_r721874961
########## File path: src/runtime/pipeline/pipeline_struct.h ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#ifndef TVM_RUNTIME_PIPELINE_PIPELINE_STRUCT_H_ +#define TVM_RUNTIME_PIPELINE_PIPELINE_STRUCT_H_ +#include <assert.h> +#include <dlpack/dlpack.h> +#include <dmlc/json.h> + +#include <string> +#include <unordered_map> +#include <vector> +/*! + * \brief All binding information of a output interface. + */ +struct OutputBindings { + /*!\brief Output interface binding information, 'int' is the index of the module that + * use this output data as the input interface data, 'string' is the input interface name + * of the module. + */ + std::unordered_map<int, std::string> bindings; + /*! + * \brief If there is one global binding in bindings, then current output is + * global interface. + * \return Whether this output interface is global output interface. + */ + bool IsGlobalOutput() const { + int num_output = 0; + for (auto binding : bindings) { + /* output is global output when value is 0. + */ + num_output += (binding.first == 0); + } + /* If this output is a global output then there is only one such output in map.*/ + ICHECK(num_output <= 1); + return num_output == 1; + } + /*! + * \brief Create module interface map from JSONReader. + * \param reader Json reader. + */ + void Load(dmlc::JSONReader* reader) { + reader->BeginArray(); + while (reader->NextArrayItem()) { + std::string key; + reader->BeginObject(); + std::string input_name; + int mod_idx = -1; + while (reader->NextObjectItem(&key)) { + if (key == "mod_idx") { + reader->Read(&mod_idx); + } + if (key == "input_name") { + reader->Read(&input_name); + } + } + ICHECK(mod_idx >= 0); Review comment: in module config file, there are 2 place have mod_idx information , first is the module list with output, here all module is graphexecutor module, and no PipelineExecutor or global module here, the second place is the binding place that use to describe which output binding with which module input/output, here the module can be graphexecutor module or PipelineExecutor/global module, because we need import data or output data for PipelineExecutor, that is the reason why in different place there are difference check logic. added related comments for the said logic explain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
