manupa-arm commented on pull request #9164: URL: https://github.com/apache/tvm/pull/9164#issuecomment-937609136
Hmmm, I was not suggesting to run the legalization before the partitioning. We could identify the patterns with QNN ops and then we partition the external function. I believe the requirement to do the legalization + constant folding comes post partitioning. So there are two places we could do this : 1) post PartitionGraph pass in the partition_for_* function 2) relay.ext.<codegen> which gets the partitioned function passed in via relay.build process. I believe, this particular requirement is to mutate only the external function (thus, we could do it 2) and not 1) ) and not the 'main'. Therefore, why cant we achieve the same effect running the two passes -- legalization + constant folding -- in 2) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
