manupa-arm commented on a change in pull request #9209:
URL: https://github.com/apache/tvm/pull/9209#discussion_r724842702
##########
File path: tests/python/driver/tvmc/test_compiler.py
##########
@@ -471,7 +471,7 @@ def test_compile_tflite_module_with_external_codegen_ethosu(
for name in mlf_package.getnames()
if re.match(r"\./codegen/host/src/\D+\d+\.c", name)
]
- assert len(c_source_files) == 17
+ assert len(c_source_files) == 4
Review comment:
We should have put a comment saying why there was 17 here originally.
Sorry about that.
Would you be able to put a comments explaining why it is 4 now ?
(It should along the lines of that we expect lesser subgraphs where it was
just conv2D being offloaded and now we have depthwise_conv2d being offloaded as
well from mobilenet. Therefore [conv2d-->dethpwise_conv2d-->conv2d-> ... ] get
fused to a single primitive external function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
