PhilippvK commented on issue #8953: URL: https://github.com/apache/tvm/issues/8953#issuecomment-939395610
@areusch You are more or less right. 1. As calculated above, 120 characters is actually not enough for worst case models using the default name prefix `default`. Therefore we do either have to increase the number even more, or make sure that the resulting names are at least 2 characters shorter. 2. Contrary to my expectations the constant `TVM_CRT_MAX_STRLEN_FUNCTION_NAME ` is currently only used in a way, which which is somehow not related to function names at all aka. for storing parameter names such as `p10`, `p35`,... (See my last message) 3. The latter does not make sense to me, therefore it feels wrong to just increase `TVM_CRT_MAX_STRLEN_FUNCTION_NAME ` even further because reserving 120 characters to store such small strings seems to be very inefficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
