masahi commented on a change in pull request #9108:
URL: https://github.com/apache/tvm/pull/9108#discussion_r727602384



##########
File path: python/tvm/contrib/pipeline_executor.py
##########
@@ -139,13 +187,14 @@ def get_owner_idx(self):
             if isinstance(self.io_owner, PipelineConfig.ModuleWrapper):
                 return self.io_owner.idx
 
-            return 0
+            return -1
 
-        def is_global_interface(self):
-            """The global interface is the interface visible to the caller 
which use a pipeline
-            executor, the global input interface is responsible for passing 
parameters to the
-            internal module interface, and the global output interface is 
responsible for
-            outputting the results computed by the pipeline executor to a 
caller.
+        def is_pipeline_executor_interface(self):
+            """The pipeline interface is used to interact with the caller, 
there are two types
+            such interfaces, one is 'input' another is 'output'. the pipeline 
input interface
+            is responsible for passing parameters to the internal module 
interface, and the
+            pipeline output interface is responsible for outputting the 
results computed by
+            the pipeline executor to a caller.

Review comment:
       ```
   The pipeline interface is used to interact with the caller. There are two 
types
               of interfaces, one is 'input' and another is 'output'. The 
pipeline input interface
               is responsible for passing parameters to the internal module 
interface, and the
               pipeline output interface is responsible for outputting the 
results computed by
               the pipeline executor to the caller.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to