vinx13 commented on a change in pull request #9224:
URL: https://github.com/apache/tvm/pull/9224#discussion_r727364832
##########
File path: tests/python/unittest/test_tvmscript_complete.py
##########
@@ -272,10 +272,30 @@ def test_complete_match_buffer():
tvm.ir.assert_structural_equal(match_buffer_func,
expected_match_buffer_func)
[email protected]_func
+def alloc_buffer_func(a: T.handle, b: T.handle) -> None:
+ A = T.match_buffer(a, [2, 2], dtype="float32")
+ B = T.match_buffer(b, [2, 2], dtype="float32")
+ # body
+ # tir.with block("root")
+ C = T.alloc_buffer([2, 2], dtype="float32")
+ A[(0, 0)] = T.float32(2)
+ C[(0, 0)] = A[(0, 0)] + B[(0, 0)]
+ B[(0, 0)] = C[(0, 0)]
+
+
+def test_complete_alloc_buffer():
+ func = alloc_buffer_func
+ rt_func = tvm.script.from_source(func.script(show_meta=True))
+ rt_mod = tvm.build(rt_func, "llvm")
+ tvm.ir.assert_structural_equal(func, rt_func)
Review comment:
let's write a `expected_alloc_buffer_func` like previous test cases and
assert structural equal
##########
File path: tests/python/unittest/test_tvmscript_complete.py
##########
@@ -272,10 +272,30 @@ def test_complete_match_buffer():
tvm.ir.assert_structural_equal(match_buffer_func,
expected_match_buffer_func)
[email protected]_func
+def alloc_buffer_func(a: T.handle, b: T.handle) -> None:
+ A = T.match_buffer(a, [2, 2], dtype="float32")
+ B = T.match_buffer(b, [2, 2], dtype="float32")
+ # body
+ # tir.with block("root")
+ C = T.alloc_buffer([2, 2], dtype="float32")
+ A[(0, 0)] = T.float32(2)
+ C[(0, 0)] = A[(0, 0)] + B[(0, 0)]
+ B[(0, 0)] = C[(0, 0)]
+
+
+def test_complete_alloc_buffer():
+ func = alloc_buffer_func
+ rt_func = tvm.script.from_source(func.script(show_meta=True))
+ rt_mod = tvm.build(rt_func, "llvm")
+ tvm.ir.assert_structural_equal(func, rt_func)
Review comment:
let's write an `expected_alloc_buffer_func` like previous test cases and
assert structural equal
##########
File path: tests/python/unittest/test_tvmscript_ops.py
##########
@@ -101,5 +101,42 @@ def test_get_valid_counts_script_func():
_check_get_valid_counts_with_numpy(f, (1, 2500, 6), 0.0, 0, 1)
[email protected]_func
+def alloc_zero_dim_buffer(a: T.handle, b: T.handle) -> None:
+ A = T.match_buffer(a, [], dtype="float32")
+ B = T.match_buffer(b, [], dtype="float32")
+ # body
+ # tir.with block("root")
+ C = T.alloc_buffer([], dtype="float32")
+ A[()] = T.float32(2)
+ C[()] = A[()] + B[()]
+ B[()] = C[()]
+
+
[email protected]_func
+def alloc_zero_dim_buffer_block(a: T.handle, b: T.handle) -> None:
+ A = T.match_buffer(a, (), "float32")
+ B = T.match_buffer(b, (), "float32")
+ with T.block([], "root"):
+ T.reads([])
+ T.writes([])
+ C = T.alloc_buffer((), "float32")
+ A[()] = T.float32(2)
+ C[()] = A[()] + B[()]
+ B[()] = C[()]
+
+
+def test_alloc_zero_dim_buffer_round_trip():
+ func = alloc_zero_dim_buffer
+ func_with_block = alloc_zero_dim_buffer_block
+ rt_func = tvm.script.from_source(func.script(show_meta=True))
+ rt_func_with_block =
tvm.script.from_source(func_with_block.script(show_meta=True))
+ rt_mod = tvm.build(rt_func, "llvm")
+ rt_mod_with_block = tvm.build(rt_func_with_block, "llvm")
+ tvm.ir.assert_structural_equal(func, func_with_block)
Review comment:
we need to do e2e test against numpy here instead of roundtrip
##########
File path: tests/python/unittest/test_tvmscript_complete.py
##########
@@ -272,10 +272,40 @@ def test_complete_match_buffer():
tvm.ir.assert_structural_equal(match_buffer_func,
expected_match_buffer_func)
[email protected]_func
+def alloc_buffer_func(a: T.handle, b: T.handle) -> None:
+ A = T.match_buffer(a, [2, 2], dtype="float32")
+ B = T.match_buffer(b, [2, 2], dtype="float32")
+ C = T.alloc_buffer([2, 2], dtype="float32")
+ A[(0, 0)] = T.float32(2)
+ C[(0, 0)] = A[(0, 0)] + B[(0, 0)]
+ B[(0, 0)] = C[(0, 0)]
+
+
[email protected]_func
+def expect_alloc_buffer_func(a: T.handle, b: T.handle) -> None:
+ A = T.match_buffer(a, [2, 2], dtype="float32", elem_offset=0, align=128,
offset_factor=1)
+ B = T.match_buffer(b, [2, 2], dtype="float32", elem_offset=0, align=128,
offset_factor=1)
+ with T.block([], "root"):
+ T.reads([])
+ T.writes([])
+ C = T.alloc_buffer([2, 2], dtype="float32", elem_offset=0, align=128,
offset_factor=1)
+ A[(0, 0)] = T.float32(2)
+ C[(0, 0)] = A[(0, 0)] + B[(0, 0)]
+ B[(0, 0)] = C[(0, 0)]
+
+
+def test_complete_alloc_buffer():
+ rt_func = tvm.script.from_source(alloc_buffer_func.script(show_meta=True))
+ rt_mod = tvm.build(rt_func, "llvm")
Review comment:
```suggestion
```
remove this as it is beyond script complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
