masahi edited a comment on issue #8412:
URL: https://github.com/apache/tvm/issues/8412#issuecomment-943168765


   See 
https://discuss.tvm.apache.org/t/relay-nn-does-relay-nn-dense-supports-multi-dimensional-input/10343/7.
 I realized that supporting more than 2D input for `dense` is extremely 
important for BERT-like model performance. In particular, without fixing this 
issue, I cannot demonstrate the performance advantage of cutlass BYOC 
https://github.com/apache/tvm/pull/9261 on transformer models over cublass 
offload. cc @comaniac @Laurawly 
   
   It would also improve TVM numbers for `bert_large` in 
https://github.com/apache/tvm/issues/8294#issuecomment-926599422, because those 
numbers were obtained without dense + activation fusion (also no fusion for 
batch_matmul).
   
   @AndrewZhaoLuo Are you going to work on this one? If not, I need to do it 
anyway before or after https://github.com/apache/tvm/pull/9261 lands. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to