gromero commented on a change in pull request #9274:
URL: https://github.com/apache/tvm/pull/9274#discussion_r730153277
##########
File path: apps/microtvm/zephyr/template_project/microtvm_api_server.py
##########
@@ -356,13 +361,16 @@ def _get_platform_version(self) -> str:
if "VERSION_MINOR" in line:
version_minor = line.split("=")[1]
- return f"{version_major}.{version_minor}"
+ return float(f"{version_major}.{version_minor}")
def generate_project(self, model_library_format_path, standalone_crt_dir,
project_dir, options):
# Check Zephyr version
version = self._get_platform_version()
if version != ZEPHYR_VERSION:
- raise ValueError(f"Zephyr version does not math: {version} !=
{ZEPHYR_VERSION}")
+ message = f"Zephyr version does not math: {version} !=
{ZEPHYR_VERSION}"
Review comment:
This still needs to get fixed. While you're at it, maybe it could give
an additional hint to the user about what zephyr version we're expecting? Maybe
something like:
```
f"Zephyr version found is not supported: found {version}, expected
{ZEPHYR_VERSION}."
```
Arduino part will need to get updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
