sergey-grovety commented on a change in pull request #9233:
URL: https://github.com/apache/tvm/pull/9233#discussion_r729871733
##########
File path: python/tvm/target/arm_isa.py
##########
@@ -16,18 +16,24 @@
# under the License.
"""Defines functions to analyze available opcodes in the ARM ISA."""
+import argparse
ARM_ISA_MAP = {
- "armv7e-m": ["SMLAD"],
+ "armv7e-m": ["SMLAD", "SSUB8", "SEL"],
+ "armv8-m": ["SMLAD", "SSUB8", "SEL"],
}
class IsaAnalyzer(object):
+ """Checks ISA support for given target"""
+
def __init__(self, target):
self.target = target
- # TODO: actually parse -mcpu
- arch = "armv7e-m"
- self._isa_map = ARM_ISA_MAP[arch]
+ parser = argparse.ArgumentParser()
Review comment:
not sure if I understand you correctly, but _target_ here is a string
##########
File path: python/tvm/target/arm_isa.py
##########
@@ -16,18 +16,24 @@
# under the License.
"""Defines functions to analyze available opcodes in the ARM ISA."""
+import argparse
ARM_ISA_MAP = {
- "armv7e-m": ["SMLAD"],
+ "armv7e-m": ["SMLAD", "SSUB8", "SEL"],
+ "armv8-m": ["SMLAD", "SSUB8", "SEL"],
}
class IsaAnalyzer(object):
+ """Checks ISA support for given target"""
+
def __init__(self, target):
self.target = target
- # TODO: actually parse -mcpu
- arch = "armv7e-m"
- self._isa_map = ARM_ISA_MAP[arch]
+ parser = argparse.ArgumentParser()
Review comment:
not sure if I understand you correctly, but _target_ here is a string
##########
File path: python/tvm/target/arm_isa.py
##########
@@ -16,18 +16,24 @@
# under the License.
"""Defines functions to analyze available opcodes in the ARM ISA."""
+import argparse
ARM_ISA_MAP = {
- "armv7e-m": ["SMLAD"],
+ "armv7e-m": ["SMLAD", "SSUB8", "SEL"],
+ "armv8-m": ["SMLAD", "SSUB8", "SEL"],
}
class IsaAnalyzer(object):
+ """Checks ISA support for given target"""
+
def __init__(self, target):
self.target = target
- # TODO: actually parse -mcpu
- arch = "armv7e-m"
- self._isa_map = ARM_ISA_MAP[arch]
+ parser = argparse.ArgumentParser()
Review comment:
not sure if I understand you correctly, but _target_ here is a string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
