ccjoechou commented on pull request #9235:
URL: https://github.com/apache/tvm/pull/9235#issuecomment-946806951
Do you like me to create a new TVM github pull request with all changes in
one upstream again so it is cleaner?
I can do that but not sure how to move all discussions over.
Please advise !
Once again, if there happen to have instructions (or sample links), which
are for “github” pull request with rebase, please point us to those so we will
not make same mistake again.
Thanks,
* Joe
From: Joe Chou
Sent: Tuesday, October 19, 2021 7:46 AM
To: apache/tvm ***@***.***>; apache/tvm ***@***.***>
Cc: Author ***@***.***>
Subject: RE: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in
pooling (#9235)
I did use rebase on my side.
But for this time around because I did not know that, for upstreaming
further changes, I have to advance my pull request’s base (main) to latest TVM
github main again; therefore, the order of my git commands were not correct –
leading to the merging situation.
Do you happen to have instructions (or sample links), which is for “github”
pull request and allows to do rebase in order upstream new changes?
Can you share those links with us so that we can follow to avoid future git
related troubles?
We have our own git server & GUI but different requirements are implemented
over there; but, we want to follow TVM github git guidelines.
Thanks,
* Joe
From: Cody Yu ***@***.******@***.***>>
Sent: Monday, October 18, 2021 7:50 PM
To: apache/tvm ***@***.******@***.***>>
Cc: Joe Chou ***@***.******@***.***>>; Author ***@***.******@***.***>>
Subject: [EXT] Re: [apache/tvm] [Op] Do not override specified layout in
pooling (#9235)
External Email
________________________________
Please use rebase instead of merge. We need to see the correct changes of
this PR, and it cannot include the commits from other PRs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on
GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_tvm_pull_9235-23issuecomment-2D946321611&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=-yW2Oqts6oW8PhsVqKlygMxGKQHZWfFSYb0ZvPbkONQ&e=>,
or
unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM636PGAEJEDSDXBTXACSH3UHTMGBANCNFSM5FUWAG4A&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=-jJkbT1vqONySNCUJQ5xWRymSYgJVvp8NNg8xUhTWow&e=>.
Triage notifications on the go with GitHub Mobile for
iOS<https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=I1dAssFokDD8qTL1IyLWBXLcPq0dglCw26sNYtyTeds&e=>
or
Android<https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=84zI-iH2xz28Q_xujSGbjYaq38CgcRgl_vGzCtF6TwQ&m=cvYw2dlkGTNlnqbrVbxm_jJT-EVbz2hXQgh1XeV3fsI&s=CE89y59UuMjK8HE8Ytf9bMy8FLbGK-KvUm3hZ2QeaH8&e=>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
