electriclilies commented on a change in pull request #9312:
URL: https://github.com/apache/tvm/pull/9312#discussion_r733231501
##########
File path: src/relay/backend/graph_plan_memory.cc
##########
@@ -147,6 +147,12 @@ class StorageAllocaBaseVisitor : public
transform::DeviceAwareExprVisitor {
*/
const std::vector<StorageToken*>& GetToken(const Expr& expr) {
this->VisitExpr(expr);
+ // Return empty if called on a Function
+ // OK actually looks like we do want to do stuff for function nodes?
+ if (expr->checked_type().as<FuncTypeNode>()) {
+ static const std::vector<StorageToken*> empty;
+ return empty;
Review comment:
it's a ref so it seg faults if you do that :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
