masahi commented on a change in pull request #9328:
URL: https://github.com/apache/tvm/pull/9328#discussion_r733258310
##########
File path: python/tvm/relay/op/nn/_nn.py
##########
@@ -515,6 +506,32 @@ def
compute_contrib_conv3d_winograd_weight_transform(attrs, inputs, out_dtype):
reg.register_pattern("nn.max_pool2d", OpPattern.OUT_ELEMWISE_FUSABLE)
[email protected]_convert_op_layout("nn.max_pool2d")
+def convert_max_pool2d(attrs, inputs, tinfos, desired_layouts):
+ """Convert Layout pass registration for max_pool2d op.
+ Parameters
+ ----------
+ attrs : tvm.ir.Attrs
+ Attributes of current pooling
+ inputs : list of tvm.relay.Expr
+ The args of the Relay expr to be legalized
+ tinfos : list of types
+ List of input and output types
+ desired_layouts : list of one layout string
+ layout string defining our desired layout for input and output.
+ Returns
+ -------
+ result : tvm.relay.Expr
+ The transformed expr
+ """
+ # stick by convertng layout and out_layout to use NHWC and NHWC,
+ # respectively, as specified in the transforms.ConvertLayout()
function's arguments later
Review comment:
I suggest removing this comments, as it doesn't much sense.
Same comment for other changes in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
