Mousius commented on a change in pull request #9335: URL: https://github.com/apache/tvm/pull/9335#discussion_r733500187
########## File path: tests/python/unittest/test_micro_transport.py ########## @@ -26,8 +26,7 @@ import tvm.testing [email protected]_micro -class TransportLoggerTests(unittest.TestCase): +def test_transport_class(): Review comment: This would be nice as a fixture as above. ########## File path: tests/python/unittest/test_micro_project_api.py ########## @@ -26,45 +26,48 @@ import tvm -pytest.importorskip("tvm.micro") -from tvm.micro import project_api [email protected] +def BaseTestHandler(): + from tvm.micro import project_api -class BaseTestHandler(project_api.server.ProjectAPIHandler): + class BaseTestHandler(project_api.server.ProjectAPIHandler): Review comment: Unsure about the name shadowing here, but this is neat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
