vinx13 commented on a change in pull request #9306:
URL: https://github.com/apache/tvm/pull/9306#discussion_r734143755
##########
File path: src/printer/tvmscript_printer.cc
##########
@@ -1343,12 +1371,60 @@ Doc TVMScriptPrinter::PrintLoopStack() {
return res;
}
+/*!
+ * \brief The printer for TVMScript with diagnostic
+ * \details The printer obtain the precedence of the top-level operation when
printing each
+ * subexpression to decide whether or not parentheses is needed.
+ */
+class TVMScriptPrinterWithDiagnostic : public TVMScriptPrinter {
+ public:
+ explicit TVMScriptPrinterWithDiagnostic(const String& tir_prefix, bool
show_meta,
+
runtime::TypedPackedFunc<std::string(Stmt)> annotate)
+ : TVMScriptPrinter(tir_prefix, show_meta, annotate) {}
+
+ protected:
+ Doc PrintBlockName(const BlockNode* block_op);
+ Doc PrintUnderline(const Stmt& stmt, int length);
+ Doc PrintLoop(const For& loop);
Review comment:
```suggestion
Doc PrintLoop(const For& loop) override;
```
##########
File path: src/printer/tvmscript_printer.cc
##########
@@ -1343,12 +1371,60 @@ Doc TVMScriptPrinter::PrintLoopStack() {
return res;
}
+/*!
+ * \brief The printer for TVMScript with diagnostic
+ * \details The printer obtain the precedence of the top-level operation when
printing each
+ * subexpression to decide whether or not parentheses is needed.
+ */
+class TVMScriptPrinterWithDiagnostic : public TVMScriptPrinter {
+ public:
+ explicit TVMScriptPrinterWithDiagnostic(const String& tir_prefix, bool
show_meta,
+
runtime::TypedPackedFunc<std::string(Stmt)> annotate)
+ : TVMScriptPrinter(tir_prefix, show_meta, annotate) {}
+
+ protected:
+ Doc PrintBlockName(const BlockNode* block_op);
Review comment:
```suggestion
Doc PrintBlockName(const BlockNode* block_op) override;
```
##########
File path: src/printer/tvmscript_printer.cc
##########
@@ -1343,12 +1371,60 @@ Doc TVMScriptPrinter::PrintLoopStack() {
return res;
}
+/*!
+ * \brief The printer for TVMScript with diagnostic
+ * \details The printer obtain the precedence of the top-level operation when
printing each
+ * subexpression to decide whether or not parentheses is needed.
+ */
+class TVMScriptPrinterWithDiagnostic : public TVMScriptPrinter {
+ public:
+ explicit TVMScriptPrinterWithDiagnostic(const String& tir_prefix, bool
show_meta,
+
runtime::TypedPackedFunc<std::string(Stmt)> annotate)
+ : TVMScriptPrinter(tir_prefix, show_meta, annotate) {}
+
+ protected:
+ Doc PrintBlockName(const BlockNode* block_op);
+ Doc PrintUnderline(const Stmt& stmt, int length);
+ Doc PrintLoop(const For& loop);
+};
+
+Doc TVMScriptPrinterWithDiagnostic::PrintBlockName(const BlockNode* block_op) {
+ Doc doc = PrintOptionalInfo(GetRef<Stmt>(block_op));
Review comment:
Is this needed? `PrintOptionalInfo` should've been called in `Print`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
